Why only update the grid in aabb?

nerfstudio-project / nerfacc

A General NeRF Acceleration Toolbox in PyTorch.

https://www.nerfacc.com/

Other

1.38k stars 112 forks source link

Why only update the grid in aabb? #126

Closed kwea123 closed 1 year ago

kwea123 commented 1 year ago

https://github.com/KAIR-BAIR/nerfacc/blob/0e1e7cb7c6f8e7e77073bc88f1333fddc7474c18/nerfacc/grid.py#L218-L222

Why don't you update the whole space?

liruilong940607 commented 1 year ago

Hi this is because the contraction formulation in MipNeRF360 contracts inf into a sphere. So I'm only update things in the sphere not the cube. Note here I'm masking the outer (2x) sphere which has radius 0.5 in a [0, 1] cube.