nerfstudio-project / nerfacc

A General NeRF Acceleration Toolbox in PyTorch.
https://www.nerfacc.com/
Other
1.38k stars 112 forks source link

Pybind11 required version #127

Closed lkskstlr closed 1 year ago

lkskstlr commented 1 year ago

Hi nerfacc team,

thank you for open-sourcing this software, it is really useful!

I wanted to ask if the pybind requirement pybind11>=2.10.0 is strict or if pybind11==2.9.2 would also be sufficient (maybe not tested)? Are there specific features of 2.10 you are using?

Thanks a lot Lukas

liruilong940607 commented 1 year ago

I didn't test on various pybind11 versions. It is very likely that a lower version would work as there is no special features being used. Personally I'm also not familiar with the change log of pybind11. Happy to take advices or PRs!!

liruilong940607 commented 1 year ago

close at not activated any more