nerfstudio-project / nerfacc

A General NeRF Acceleration Toolbox in PyTorch.
https://www.nerfacc.com/
Other
1.39k stars 114 forks source link

fixed a hang bug in ray_marching #136

Closed dozeri83 closed 1 year ago

dozeri83 commented 1 year ago

fixed a hang bug where t_target has inf value ( ray is parralel to plane ?) t_target should not be larger that far anyway

@tancik I found the hang bug - t_target got inf value. if we bound it by far - it fixes the issue.

This is related to https://github.com/nerfstudio-project/nerfstudio/issues/1152.

The problem is that I see that nerfstudio is incompatible with the newest version of nerfacc, so a work needs to be done in nerfstudio to upgrade nerfacc.

liruilong940607 commented 1 year ago

LGTM! thanks for the fix!