search

nerfstudio-project / nerfacc

A General NeRF Acceleration Toolbox in PyTorch.
https://www.nerfacc.com/
Other
1.38k stars 112 forks source link

Why the alpha_thre and early_stop_eps is removed from rendering() in the latest version? #139

Open SevenLJY opened 1 year ago

SevenLJY commented 1 year ago

Hi Ruilong,

I noticed that you removed alpha_thre and early_stop_eps args from the rendering() in the latest version. I'm wondering if this feature will have a negative impact on the rendering quality.

liruilong940607 commented 1 year ago

Hey we moved these two argument to the ray_marching() as logically the skipping should be handled in the marching step. The rendering() would render all the samples from ray_marching(). This is actually the same behavior as before where we default the alpha_thre to 0, and early_stop_eps to the same value as in ray_marching(). We recognize this is redundant and it won't cause any negative impact on the rendering quality.