nerfstudio-project / nerfacc

A General NeRF Acceleration Toolbox in PyTorch.
https://www.nerfacc.com/
Other
1.37k stars 113 forks source link

chore: drop `MANIFEST.in` #167

Closed SauravMaheshkar closed 1 year ago

SauravMaheshkar commented 1 year ago

This PR aims to minimize the overall project structure by adding the extra include information by specifying the include argument in the find_packages() function in setup.py

@liruilong940607 Request for Review

liruilong940607 commented 1 year ago

Hi I think MANIFEST.in is the suggested way by setuptools for maintaining package data. Also specifying include in the find_package() does not seem to do the job -- From what I know it only searchs for python package with the file __init__.py -- And I think this is the reason that fails the build doc test.

SauravMaheshkar commented 1 year ago

Makes sense, forgot that include searches only for python packages.