An issue in the example code

nerfstudio-project / nerfacc

A General NeRF Acceleration Toolbox in PyTorch.

https://www.nerfacc.com/

Other

1.37k stars 113 forks source link

Closed FrozenSilent closed 1 year ago

FrozenSilent commented 1 year ago

Hi! Thanks for this useful tool for NeRF accelerating. I have found a bug in the example code. If batch_over_images in the data loader is set to False, running the example code will result in an error. I have figured out that the following line https://github.com/KAIR-BAIR/nerfacc/blob/ebeb5ddf733c04b425d5070efae9c3d23f64b078/examples/datasets/dnerf_synthetic.py#L179 should be changed to

image_id = [index] * num_rays

liruilong940607 commented 1 year ago

yeah you are right that should be the fix! Feel free to open a PR if you want

FrozenSilent commented 1 year ago

Sure! I have opened a PR.

liruilong940607 commented 1 year ago

Close it as fixed!