bug in train_ngp_nerf.py

nerfstudio-project / nerfacc

A General NeRF Acceleration Toolbox in PyTorch.

https://www.nerfacc.com/

Other

1.38k stars 112 forks source link

Closed CZ-Wu closed 1 year ago

CZ-Wu commented 1 year ago

It seems a bug here:

https://github.com/KAIR-BAIR/nerfacc/blob/e7bd2074c583c287b9d0f575398b68a2517cb546/examples/train_ngp_nerf.py#L203

should be if (near_plane is not None) and (far_plane is not None):?

CCamouflage-Hvv commented 1 year ago

I have the same question. Hope a senior guy come to explain. Thanks!

liruilong940607 commented 1 year ago

Good catch. Yeah it is a typo just fixed. It shouldn't cause any issue by far as near far planes are either both None, or both valid.