nerfstudio-project / nerfstudio

A collaboration friendly studio for NeRFs
https://docs.nerf.studio
Apache License 2.0
9.34k stars 1.26k forks source link

Compatibility for numpy 2.0 #3265

Closed kerrj closed 3 months ago

kerrj commented 3 months ago

WIP for supporting numpy 2.0. Our builds were breaking because of numpy 2.0, I added the automatic ruff linting as described here, and also upgraded OpenCV to 4.10 as described here.

@jb-ye @f-dy I seem to remember there was some reason we pinned OpenCV to 4.8 related to the undistorting code, do you know if that's still important?

kerrj commented 3 months ago

There are a lot of tiny file changes because of the new ruff lint version

jb-ye commented 3 months ago

See https://github.com/nerfstudio-project/nerfstudio/pull/2726#issuecomment-1883065838

I am fine with moving forward with newer version of opencv.