search

nerfstudio-project / nerfstudio

A collaboration friendly studio for NeRFs
https://docs.nerf.studio
Apache License 2.0
9.25k stars 1.24k forks source link

DepthRenderer method='median' is not differentiable #3334

Open gtangg12 opened 1 month ago

gtangg12 commented 1 month ago

https://github.com/nerfstudio-project/nerfstudio/blob/702886b213a5942b64250b3c4dc632e62237a511/nerfstudio/model_components/renderers.py#L330

requires_grad=False while for expected its True

Seems like it will create a lot of "why is this not learning issues" downstream. Perhaps an improvement would be to raise a warning.

peasant98 commented 1 month ago

I agree, it might be good to have the method as "expected" by default

There was a small bug where expected depth wasn't previously used in depth-nerfacto:

https://github.com/nerfstudio-project/nerfstudio/pull/2852/files