neroden / timetable_kit

A Python toolkit for generating human-readable timetables from GTFS data; uses PANDAS and gtfs_kit
GNU Affero General Public License v3.0
39 stars 2 forks source link

Clean up imports, typos, and leftovers. #12

Closed Borketh closed 1 year ago

Borketh commented 1 year ago

This is the first of a few PRs broken out from #11. In this PR are the import fixes, which add forgotten error imports, remove unused imports, and rearrange everything to fit python guidelines. Additionally, typos and unnecessary leftover bits of code are fixed.

Please note I am respecting your opinion on the version spec for everything else, but poetry would not let me install the dependencies with the spec for python itself being >=.

neroden commented 1 year ago

Merged. Thank you. Corrected one thing ("station_list_commaed" meant "station_list_with_commas").

Version spec on Python is fine. If we ever updated to Python 4 it probably would break everything. And I don't expect Python 4 to come out for a long time -- it's not nearly as fast-moving a target as the other stuff (where I want to make sure I'm coding to the most recent version).