search

neroden / timetable_kit

A Python toolkit for generating human-readable timetables from GTFS data; uses PANDAS and gtfs_kit
GNU Affero General Public License v3.0
39 stars 2 forks source link

Possible station list edge case #7

Closed cpbnj closed 1 year ago

cpbnj commented 2 years ago

This may be an Amtrak GTFS issue, but I've noticed that in the Crescent timetables posted on narprail.org, the suburban New Jersey stops (Princeton Jct, New Brunswick, Metropark) for train 20 are not listed. I believe those stops were added in Oct 2021. If not a GTFS issue, this could be an edge case where a train pair makes different stops in each direction.

neroden commented 2 years ago

I might have missed them because train 21 doesn't stop there. But it's probably a GTFS issue. I'm currently waiting for new GTFS since there are a bunch of known bugs in the current GTFS. :-( Will check on this when I get back to working on this.

-- Nathanael C. Nerode @.***

On Sun, Aug 28, 2022, at 10:28 AM, cpbnj wrote:

This may be an Amtrak GTFS issue, but I've noticed that in the Crescent timetables posted on narprail.org, the suburban New Jersey stops (Princeton Jct, New Brunswick, Metropark) for train 20 are not listed. I believe those stops were added in Oct 2021. If not a GTFS issue, this could be an edge case where a train pair makes different stops in each direction.

-- Reply to this email directly or view it on GitHub: https://github.com/neroden/timetable_kit/issues/7 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

cpbnj commented 2 years ago

Perhaps Amtrak will someday realize that sunlight is the best disinfectant and will publish their buggy GTFS data for public consumption and feedback. Thank you for taking the time to create this open source toolkit and for the excellent timetables you produced with it.

On Wed, Aug 31, 2022 at 2:39 PM Nathanael Nerode @.***> wrote:

I might have missed them because train 21 doesn't stop there. But it's probably a GTFS issue. I'm currently waiting for new GTFS since there are a bunch of known bugs in the current GTFS. :-( Will check on this when I get back to working on this.

-- Nathanael C. Nerode @.***

On Sun, Aug 28, 2022, at 10:28 AM, cpbnj wrote:

This may be an Amtrak GTFS issue, but I've noticed that in the Crescent timetables posted on narprail.org, the suburban New Jersey stops (Princeton Jct, New Brunswick, Metropark) for train 20 are not listed. I believe those stops were added in Oct 2021. If not a GTFS issue, this could be an edge case where a train pair makes different stops in each direction.

-- Reply to this email directly or view it on GitHub: https://github.com/neroden/timetable_kit/issues/7 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/neroden/timetable_kit/issues/7#issuecomment-1233285396, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACL6WOLCHE2HJW3LK7OKWCDV36RGHANCNFSM573FF5BQ . You are receiving this because you authored the thread.Message ID: @.***>

neroden commented 1 year ago

They're in the GTFS, I just missed them because they're only stops in one direction and I looked at the other direction.

Fixed with https://github.com/neroden/timetable_kit/commit/347d7b245ec60c88f90683c60c0c75313f7a16d8