nerubia / kh360-react

KH360 Frontend
0 stars 0 forks source link

Skill Map Forms - incorrect Previous Rating data #1095

Open rrosel opened 4 months ago

rrosel commented 4 months ago

Issue - Data is not updated, "No Rating" is displayed on new submitted and previous submitted skills. image

Expected: Previous Rating - base from latest skill map period end date, then latest submitted date.

chadiegilnerubia commented 4 months ago

FE:https://github.com/nerubia/kh360-react/pull/1096 BE:https://github.com/nerubia/kh360-nodejs/pull/613

Acey06 commented 4 months ago

The ongoing skill form still doesn't display previous ratings.

image

Based on the screenshot, Guiann's account has already submitted skill map forms, , and this is evident in the submitted section as well.

image

rrosel commented 4 months ago

Not OK in Beta

Issue - Some submitted skills displayed No Rating.

Screenshare - 2024-05-21 4 31 53 PM(1).webm

Screenshare - 2024-05-21 4 37 49 PM.webm

Acey06 commented 4 months ago

Not Ok in Beta

Image

Image

gborgonia-ir commented 3 months ago

Did some verification on local to bypass current db issue on beta.

It seems there are still issues under Previous Rating column.

Skill Map 1 (test 1) - correct Previous Rating Skill Map 2 (test 2) - incorrect Previous Rating for CSS and HTML, it should be both Beginner Skill Map 3 (test 3) - correct Previous Rating Skill Map 4 (test 4) - correct Previous Rating. Incorrect default Rating on slider, should reflect what is on Previous Rating value

Image Image Image Image

@chadiegilnerubia pls check

rrosel commented 3 months ago

OK in Beta

Screenshare - 2024-06-19 9 43 04 AM.webm