search

nerves-hub / nerves_hub_cli

NervesHub Mix command line interface
Apache License 2.0
36 stars 17 forks source link

Fix compile warning #153

Closed jjcarstens closed 4 years ago

jjcarstens commented 4 years ago

Recently updated nerves_hub_cli which subsequently updated to nerves_hub_user_api 0.7 that changed some API functions and gives these deprecation warnings:

warning: NervesHubUserAPI.Device.cert_list/4 is deprecated. use NervesHubUserAPI.DeviceCertificate.list/4 instead
  lib/mix/tasks/nerves_hub.device.ex:403: Mix.Tasks.NervesHub.Device.cert_list/3

warning: NervesHubUserAPI.Device.cert_sign/5 is deprecated. use NervesHubUserAPI.DeviceCertificate.sign/5 instead
  lib/mix/tasks/nerves_hub.device.ex:560: Mix.Tasks.NervesHub.Device.do_cert_create/1

This updates CLI to use the new functions (since we prob should emit warnings for our own lib 😆 )

Also adds mix compile --warnings-as-errors to the CI to help catch things like this in the future.