nerves-hub / nerves_hub_link

Connect devices to NervesHub via a Phoenix channel
https://hex.pm/packages/nerves_hub_link
Apache License 2.0
36 stars 18 forks source link

Use `Slipstream.push/5` for safe publishing #109

Closed jjcarstens closed 2 years ago

jjcarstens commented 2 years ago

We've recently run into a condition where another failure caused the socket to crash, but fwup was still applying an update sending messages to new socket process which hadn't joined the channel yet. push!/4 would then crash the socket again and repeat the cycle.

In most cases, these messages are not critical so switch to the safe push/5 version, we can avoid needless crashes and still be okay on the web side