search

nerves-hub / nerves_hub_link

Connect devices to NervesHub via a Phoenix channel
https://hex.pm/packages/nerves_hub_link
Apache License 2.0
36 stars 18 forks source link

Remove the `[] =` for fwup_public_keys #204

Closed oestrich closed 4 months ago

oestrich commented 4 months ago

This caused a pattern match error when public key(s) were present because this was matching against an empty list.

fhunleth commented 4 months ago

How did this ever work? Is it recent?

oestrich commented 4 months ago

It’s from maybe a month ago but we haven’t had a release from even longer. Guess no one ran it when we merged it? 🤷

fhunleth commented 4 months ago

Which commit/PR?

oestrich commented 4 months ago

This was the pr https://github.com/nerves-hub/nerves_hub_link/pull/187

fhunleth commented 4 months ago

Could you revise the commit message so that it's (or revise if I got it wrong):

Fix regression that prevents using fwup public keys

Commit 3275db2e added an empty list pattern match that would
fail when a key was present. Fix issue by removing the match.

Change looks good.

joshk commented 4 months ago

Thanks for catching this @oestrich