search

nerves-hub / nerves_hub_link

Connect devices to NervesHub via a Phoenix channel
https://hex.pm/packages/nerves_hub_link
Apache License 2.0
36 stars 18 forks source link

heartbeat_interval_msec is a top level config value #205

Closed oestrich closed 4 months ago

joshk commented 4 months ago

Thanks for catching this @oestrich

@fhunleth @oestrich , should we consider moving reconnect_after_msec to the top level as well to match?

fhunleth commented 4 months ago

@joshk I'm not opposed, but it would be a backwards incompatible change. Perhaps consider for next release? I'm anxious to get the back pressure fix out.

joshk commented 4 months ago

Totally understand.

I’d suggest we move the setting under socket to match, but I don’t want to hold up the release.

Sent from my Commodore 64

On Tue, 25 Jun 2024 at 1:41 PM, Frank Hunleth @.***> wrote:

@joshk https://github.com/joshk I'm not opposed, but it would be a backwards incompatible change. Perhaps next consider for next release? I'm anxious to get the back pressure fix out.

— Reply to this email directly, view it on GitHub https://github.com/nerves-hub/nerves_hub_link/pull/205#issuecomment-2187761517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACD7P4EIUMWUZVQJDWWFLZJDDEVAVCNFSM6AAAAABJ2EP4T6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXG43DCNJRG4 . You are receiving this because you were mentioned.Message ID: @.***>