Report fwup version to nerves hub

nerves-hub / nerves_hub_link

Connect devices to NervesHub via a Phoenix channel

https://hex.pm/packages/nerves_hub_link

Apache License 2.0

36 stars 18 forks source link

Report fwup version to nerves hub #44

Closed Mrjaco12 closed 4 years ago

Mrjaco12 commented 4 years ago

Why:

NH needs to know the fwup version to make decisions about delta updates
Resolves Issue #43

This change addresses the need by:

Grab fwup version when creating config
Add fwup version to config params
Add a spec to check that fwup version key is present

Mrjaco12 commented 4 years ago

@mobileoverlord @fhunleth let me know what you guys think about this. The test is pretty naive and would fail in a testing env without fwup installed so that's a downside but the tradeoff of extracting a module and creating a mock for this didn't really seem worth it.

fhunleth commented 4 years ago

IMHO, fwup should be installed everywhere, so I think we should just view that as a given. ;)