search

nerves-hub / nerves_hub_link

Connect devices to NervesHub via a Phoenix channel
https://hex.pm/packages/nerves_hub_link
Apache License 2.0
36 stars 18 forks source link

Implement NervesHubLink.Client.handle_fwup_message/2 #70

Closed jjcarstens closed 3 years ago

jjcarstens commented 3 years ago

This allows us to pass firmware meta data about the fwup message to the client as well as the web.

Alternate to #69

ConnorRigby commented 3 years ago

I like this much better than #69. still pondering on it a little bit.

jjcarstens commented 3 years ago

Changing the client behavior is just a bonus. But we could probably do without it, or punt until there is a need. That would greatly simplify this PR

ConnorRigby commented 3 years ago

Changing the client behavior is just a bonus. But we could probably do without it, or punt until there is a need. That would greatly simplify this PR

I like the behaviour change, especially since it's backwards compatible.

ConnorRigby commented 3 years ago

This turned out to not be necessary. See #71