nerves-hub / nerves_hub_web

Manage firmware updates for Nerves devices
https://nerves-hub.org/
Apache License 2.0
184 stars 69 forks source link

Add devices filter to list untagged devices #1482

Closed lawik closed 4 weeks ago

lawik commented 1 month ago

If all deployments are tagged it becomes relevant to add tags to new devices. Finding devices which are untagged has been impossible using the current set of filters.

This adds a filter for Untagged devices.

lawik commented 4 weeks ago

Both flip it and reverse it? Absolute madman :)

Not sure the inverse is a large improvement.

joshk commented 4 weeks ago

for me only_untagged doesn't read well. has_tags feels nicer.

lawik commented 4 weeks ago

I prefer how that reads but not what it implies for defaults. What's the default? has_tags: true, implies showing only things with tags has_tags: false, implies showing only things without tags has_tags: ??, implies left blank

I guess we could do empty string to blank it as with other defaults but I think I prefer a boolean. How about has_no_tags?

joshk commented 4 weeks ago

+1 on has_no_tags or empty_tags