Animations refactor - Githubissues

nerves-keyboard / xebow

Firmware for the Keybow written in Elixir

40 stars 10 forks source link

Animations refactor #54

Closed doughsay closed 4 years ago

doughsay commented 4 years ago

Closes: #42, Closes: #51

TODO:

[ ] Fix the tests
[ ] Add configuration options to each animation that should have them
[ ] Fix TODOs/FIXMEs in some of the animations
[ ] Decide on what to do about the "flash" functionality we used to have

amclain commented 4 years ago

Closes: #43

Do we want to keep the layout design issue open to explore things like the keyboard-layout-editor format?

doughsay commented 4 years ago

Do we want to keep the layout design issue open to explore things like the keyboard-layout-editor format?

Sure I guess; or we can create a new issue for that. The issue specifically states supporting non-grid layouts, which this PR addresses, even though we don't use it.