search

nerves-keyboard / xebow

Firmware for the Keybow written in Elixir
40 stars 10 forks source link

Add credo to CI pipeline #85

Closed vanvoljg closed 4 years ago

vanvoljg commented 4 years ago

We've got Credo!

I had to make a couple changes because of the nesting depth refactor in RGBMatrix.Animation.SolidReactive

The FIXME and TODO notes have been converted into Issues. Warnings have been addressed (usage of :os.cmd instead of System.cmd, and there was a call to IO.inspect).

closes #74

amclain commented 4 years ago

We may also want to turn these off in the credo config:

You can deactivate these checks by adding this to the `checks` list in your config:

    {Credo.Check.Refactor.MapInto, false},
    {Credo.Check.Warning.LazyLogging, false},

MapInto

# only avaible in Elixir < 1.8 since performance improvements have since made this check obsolete

https://github.com/rrrene/credo/blob/master/lib/credo/check/refactor/map_into.ex#L1-L2

LazyLogging

elixir_version: "< 1.7.0",

https://github.com/rrrene/credo/blob/master/lib/credo/check/warning/lazy_logging.ex#L4