nerves-networking / vintage_net_mobile

Mobile networking for VintageNet
Apache License 2.0
27 stars 11 forks source link

Move mobile parameters under vintage_net_mobile key #47

Closed fhunleth closed 4 years ago

fhunleth commented 4 years ago

This makes this VintageNet technology consistent with the other technologies by having it manage its configuration under its own namespace.

The second change that was made is that modem_opts are not under the vintage_net_mobile namespace. It didn't seem useful any longer to have them buried any more deeply. This only affects the BG96.

Lastly a few simplifications were made to the unit tests. They don't change anything but it makes it easier to compare tests from different modems to see how they differ.

fhunleth commented 4 years ago

I feel like I'm done making sweeping changes to the configuration API.

The additional changes that I can think of are more modem-specific and service provider-specific keys. Neither of these seem like major changes.

If you think there's something I'm missing, please let me know soon-ish. I'd like to get a release out so that anyone using vintage_net_mobile can update to it before putting a device in a remote location. I'd expect future changes to have migrations.