search

nerves-project / nerves_system_bbb

Base Nerves system configuration for the BeagleBone-based boards
Apache License 2.0
36 stars 40 forks source link

fwup: Consolodate duplicate metadata into fwup_include/fwup-common.conf #340

Closed ConnorRigby closed 3 months ago

ConnorRigby commented 3 months ago

There is duplication of a set of defined variables between the fwup.conf and fwup-ops.conf. This PR eliminate this duplication by putting the common variable definitions into a file: fwup_include/fwup-common.conf and then includes it in fwup.conf and fwup-ops.conf with:

include("${NERVES_SDK_IMAGES:-.}/fwup_include/fwup-common.conf")

This allows the file to be found correctly in all the build environments where it is referenced. In one, the ${NERVES_SDK_IMAGES} variable exists and will be used and in the other it doesn't exist and the default value of . works there too