nerves-project / nerves_system_br

Platform infrastructure for embedded Erlang/OTP, Elixir, and LFE projects
http://nerves-project.org
GNU General Public License v2.0
409 stars 85 forks source link

Add explicit check for $TMPDIR before calling mktemp in merge-squashfs #782

Closed schrockwell closed 8 months ago

schrockwell commented 8 months ago

This is a follow-up to #778 and a proposed fix for #781.

Here's what I know:

So, my proposed solution avoids -t and -p and is about as simple and explicit as possible, and it has been tested as working equally well on macOS 13, 14, and Ubuntu 18, and with or without $TMPDIR being set.

fhunleth commented 8 months ago

@schrockwell Thank you for this alternative implementation! It makes a lot of sense to me and you've tested it well. I'm going to test it in a few more places and hopefully we can get this in.

fhunleth commented 8 months ago

Thanks again for fixing this!