search

nerves-web-kiosk / webengine_kiosk

Qt WebEngine-based kiosk
Other
74 stars 14 forks source link

add event system + add QtWebChannel #26

Closed pavels closed 3 years ago

pavels commented 4 years ago

This commit adds event system, where you can subscribe to browser events from external Elixir process.

Also it adds possibility to send messages through QtWebChannel back and use the event system to receive these messages from external Elixir process.

I needed to add one supervisor to decouple the event registry from the main GenServer. I tried to keep all the external API the same, that's why some places can look a bit weird.

fhunleth commented 4 years ago

Nice!

This seems like a really useful addition. I'm haven't been using webengine_kiosk, so let me check around that this doesn't break anyone and then I'll merge. @mobileoverlord - do you have qualms if I merge?

Thanks!!

pavels commented 4 years ago

Hi

any chance of this getting merged? Is there something i can do / change / fix?

fhunleth commented 4 years ago

Sorry, I haven't found anyone who wants to test this or take over maintenance for this project. If you're interested in maintaining it, I will create a GitHub organization, transfer it there, and give you permission to it and the ability to push to hex.pm. I'm on the Elixir lang slack if you want to discuss this more.

mobileoverlord commented 4 years ago

@pavels Now that we are moved over to the new Org, I hooked up CI. Looks like your PR just needs to have the code formatted and we can power forward. Here is the build output https://app.circleci.com/pipelines/github/nerves-web-kiosk/webengine_kiosk/1/workflows/407ab0f2-17c3-473b-ada0-4214e0584570/jobs/93

pavels commented 4 years ago

So this should be fine now i hope, can we merge @mobileoverlord ?

mobileoverlord commented 4 years ago

Sigh, Github is not attributing my comments to code......

pavels commented 4 years ago

I refactored the merge request - now it should properly survive crash of any of it's parts

pavels commented 3 years ago

@mobileoverlord Can you please take a look at the changes?

fhunleth commented 3 years ago

@pavels Justin has been super busy at work the past week and into this one. I think that that you should merge this, bump the version number to 0.3.0 and make a release. As he frees up I'm sure that he'll understand and I also think that he'll appreciate that you waited for his comments this long. I'll help with the release if you need it.