search

nervetattoo / banner-card

A fluffy banner card for Home Assistant 🥰
MIT License
606 stars 58 forks source link

Map attributes #113

Closed mikesplain closed 3 years ago

mikesplain commented 3 years ago

Add the ability to map attributes the way we already can for map_state. This works well for things like media players where you may want to look up attribute values and map it to ui values.

Fixes https://github.com/nervetattoo/banner-card/issues/109

nervetattoo commented 3 years ago

Awesome, thanks! Only problem is that the latest version of the code resides in the beta branch and has been ported to Typescript and re-organized. Do you want to re-apply the fix towards the beta branch? If not I can manually merge it and port it when I find the time, making sure that I attribute the commit to you.

mikesplain commented 3 years ago

Thanks @nervetattoo! Rebased and retargeted to the beta branch, thanks for the clean migration to TS, super easy rebase. Let me know if you need anything else from me!

nervetattoo commented 3 years ago

Looked clean and nice. Thanks for the addition, it makes super sense so 👍

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.0.0-beta.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

mikesplain commented 3 years ago

Awesome thanks! I have some more code that I’ll rework and contribute soon too. Thanks for the great plugin!