nervgh / angular-file-upload

[ALMOST NOT MAINTAINED] Angular File Upload is a module for the AngularJS framework
MIT License
3.43k stars 1.13k forks source link

Voting: Do you need a directive generate thumbnails for images in standard module package? #45

Open nervgh opened 10 years ago

nervgh commented 10 years ago

Yes/no? Comments are optional.

Demo - uploads only images (with canvas preview)

RastoStric commented 10 years ago

For me no.

kurtfunai commented 10 years ago

No

Comments: I don't need it - but I do like the idea of it being optional. It is included in the blueimp file upload that many people are used to (http://blueimp.github.io/jQuery-File-Upload/angularjs.html)

JonCognioDigital commented 10 years ago

Yes, I didn't realise that it wasn't in the standard module because I downloaded the min.js version and couldn't understand why the example code wasn't producing thumbnails on my test. Very confusing to leave it in the examples and not include it in the package.

viveks-m commented 10 years ago

+1 Yes

veewee commented 10 years ago

+1 Yes

maku commented 10 years ago

+1 Yes

davidwparker commented 10 years ago

No, I like creating my own directive for it.

martinsznapka commented 10 years ago

Yes

theninthnode commented 10 years ago

Yes

stevesuh commented 10 years ago

Yes

alexandr2110pro commented 9 years ago

yes

But just a very basic implementation with maximum flexibility.

"flexibility" is the first motivation to use your plugin.

If i will someday need a plugin that will do everything for me i'll take another one. But i will keep in mind, that such decision will force me to use strict flow and exact implementation scenario.

But can hardly imagine the real-life reason to do so.

rboughani commented 9 years ago

for me no

devmark commented 9 years ago

+1 Yes

gregpalaci commented 9 years ago

Yes

azharkhan commented 9 years ago

for image uploads, this is crucial. I was previously using v0.5 and I was able to generate thumbnails manually:

uploader.onAfterAddingFile = function(item) {
      var _URL = $window.URL || $window.webkitURL;
      var img = new Image();
      img.onload = function() {
        if (this.width !== 1200 || this.height !== 627) {
          uploader.removeFromQueue(item);
          toastr.error('Image size is not 1200x627!');
          scope.$apply();
        }
      };
      img.src = _URL.createObjectURL(item.file);
      item.imgSrc = img.src;
      updateSrcs();
    };

however now, since the item.file is a FileLikeObject, this doesn't work anymore.

ooqiaDev commented 9 years ago

@azharkhan..... Maybe item._file works.

azharkhan commented 9 years ago

@ooqiaDev thanks for the help, I noticed that in the directive code that was in the example, and it solved the problems I was having. I appreciate the help.

I'm wondering why the FileLike object was created, (out of curiosity), rather than just using the File object.

abhisheknjain commented 9 years ago

Yes please... there are uploaded images on the server and when I load the page I want to them to be displayed. It will be a great help. Thanks in advance.

yoghi commented 9 years ago

+1

mort3za commented 9 years ago

Yes

abhisheknjain commented 9 years ago

yes On Jul 1, 2015 3:48 PM, "Morteza Ziaeemehr" notifications@github.com wrote:

Yes

— Reply to this email directly or view it on GitHub https://github.com/nervgh/angular-file-upload/issues/45#issuecomment-117582650 .

ihr-it-projekt commented 6 years ago

+1

heyantonvolkov commented 6 years ago

Hello! Can't see on the docs - is this feature available now?