search

nervgh / angular-file-upload

[ALMOST NOT MAINTAINED] Angular File Upload is a module for the AngularJS framework
MIT License
3.44k stars 1.13k forks source link

Its not compatible with Angular 1.3/1.4 #469

Closed codeomnitrix closed 8 years ago

codeomnitrix commented 8 years ago

Hi,

I am using this plugin with angular js 1.4 but it seems that its not compatible with this version, can you please look into this issue since there has been a lot of changes since angular 1.1 version which you are using in your examples.

Error log - Zb @ angular.js:8496(anonymous function) @ angular-file-upload.js:408 r @ angular.js:323 module.value.factory.FileUploader._transformResponse @ angular-file-upload.js:407 module.value.factory.FileUploader._xhrTransport.xhr.onload @ angular-file-upload.js:470

ionox0 commented 8 years ago

I believe I may be having issues with trying to use Angular 1.4.3 as well

Is this an acknowledged dependency issue?

asakalou commented 8 years ago

Are there any plans to support Angular 1.4 ?

codeomnitrix commented 8 years ago

I have created a fork of this current repository at https://github.com/codeomnitrix/angular-file-upload which is compatible with angular 1.4 please let me know if you face any issue. I have created a pull request as well so will upload here once its approved.

bkingon commented 8 years ago

@nervgh Could we possibly get this merged in?

tizot commented 8 years ago

@nervgh Up :) (btw, thanks for this great plugin!!)

jlien-calwater commented 8 years ago

@nervgh bumping for 1.4 support.

majestix508 commented 8 years ago

@nervgh please support for 1.4 or maybe a merge from the codeomnitrix repo

arshtepe commented 8 years ago

I took this task.

dud3 commented 8 years ago

@nervgh bumping for 1.3/1.4.

arshtepe commented 8 years ago

I tested with angular 1.4, 1.3 and all works. Tested on ubuntu, chrome 44 and firefox 39, nodejs server response: string, json. I need more information, what does not work?

bkingon commented 8 years ago

@cyberua The bower.json file has "angular": "~1.2.11" in it, and so we are unable to use it with angular 1.3/1.4

majestix508 commented 8 years ago

I use it with angular 1.4.4 and it works so far. Just one warning: Warning: mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create

arshtepe commented 8 years ago

@bkingon I tested, everything works on 1.4.4, we will chabge soon version in bower.json

tregusti commented 8 years ago

Looking forward to the dep bump! :+1:

plainlystated commented 8 years ago

+1

nervgh commented 8 years ago

8efa7ded6fdef10938e20f7ec5021ea80227adff