search

nervgh / angular-file-upload

[ALMOST NOT MAINTAINED] Angular File Upload is a module for the AngularJS framework
MIT License
3.44k stars 1.13k forks source link

Bug in IE setting xhr.timeout before xhr.open() in version 2.6.0 #874

Open Udofalcon opened 3 years ago

Udofalcon commented 3 years ago

The latest 2.6.0 update introduced a bug with Internet Explorer where we're setting xhr.timeout before calling xhr.open(). Internet Explorer cannot handle setting those keys on the XHR object without the request being open.

image

We encountered this bug while trying to upload a file, but we were able to boil the issue down to just this section: https://github.com/nervgh/angular-file-upload/blob/master/src/services/FileUploader.js#L516-L525

Moving xhr.timeout = item.timeout || 0; after xhr.open(item.method, item.url, true); should resolve this issue.

This same bug doesn't seem to be present in Firefox, Chrome, or Edge.

ygj6 commented 3 years ago

Can you provide IE version?

Udofalcon commented 3 years ago

IE 11. Specifically 11.836.18362.0.

ygj6 commented 3 years ago

IE 11. Specifically 11.836.18362.0.

Thanks for open this issue

luumik commented 3 years ago

I know this is almost not maintained, but could you also make this so that the fix would execute when source maps are in use (minified or not). Also it would be nice to have the version via npmjs.com.