Improve the verification of v value in signature

nervosnetwork / ckb-auth

A consolidated library featuring numerous blockchains authentication techniques on CKB-VM

MIT License

9 stars 12 forks source link

Closed joii2020 closed 10 months ago

joii2020 commented 10 months ago

Verify the range of v in sign more strictly based on official documentation or code.

Bitcoin: Certainly, there are no issues. Simply adhere to BIP137 in its entirety.
Ethereum: Based on his code, it could be 0, 1, 27, or 28. However, according to the description in EIP155, it could also be v = CHAIN_ID * 2 + 35 or v = CHAIN_ID * 2 + 36. I see EIP-155 mentioned here

Test cases are being improved.

XuJiandong commented 10 months ago

@janx Could you review this change, especially the Ethereum part.

KaoImin commented 10 months ago

LGTM except the annotation