search

nervosnetwork / ckb-cli

CKB command line interface
MIT License
55 stars 35 forks source link

Let `ckb-cli deploy sign-txs` write signatures into the info file #571

Closed doitian closed 6 months ago

doitian commented 6 months ago

Since apply-txs will read signatures from the info file, it's better that sign-txs can write the signatures to the info file directly.

Related to https://github.com/nervosnetwork/ckb-cli/issues/569

Also notice that the output data sturcture of sign-txs is not consistent with the cell_tx_signatures schema in the info file.

XuJiandong commented 6 months ago

It can be archived by appending " --add-signatures ":

ckb-cli deploy sign-txs \
    --add-signatures \
    --info-file info.json
doitian commented 6 months ago

It can be archived by appending " --add-signatures ":

ckb-cli deploy sign-txs \
    --add-signatures \
    --info-file info.json

It works. Curious why it is not the default option.