search

nervosnetwork / ckb-cli

CKB command line interface
MIT License
55 stars 35 forks source link

Fix deploy with multisig #593

Closed jjyr closed 3 months ago

jjyr commented 3 months ago

Deploy with multisig will output invalid address error if address isn't Short.

This PR fixed the issue by copy the parsing code from https://github.com/nervosnetwork/ckb-cli/blob/develop/src/subcommands/tx.rs#L575

sunchengzhu commented 3 months ago

I suggest removing the description of this bug from the wiki documentation after the bug is fixed.

Then the [multisig_config] section we add above multisig lock script for future use (update cell binary**. NOTE : due to a bug, the address in sighash_addresses list must all be short sighash address.

doitian commented 3 months ago

I suggest removing the description of this bug from the wiki documentation after the bug is fixed.

Then the [multisig_config] section we add above multisig lock script for future use (update cell binary**. NOTE : due to a bug, the address in sighash_addresses list must all be short sighash address.

Done. Add a version condition to the wiki.