search

nervosnetwork / ckb-integration-test

0 stars 6 forks source link

fix(sync): rename ckb tar filename, instead of JOB_ID(may contains il… #94

Closed chanhsu001 closed 2 years ago

chanhsu001 commented 2 years ago

Summary

rename ckb tar filename, instead of JOB_ID(may contains illegal char for filename)

Bug Description

if JOB_ID contains some illegal char for filename, eg. '/', tar command will fail, and the rest of actions fails too.

Fix

new TAR_FILENAME="ckb.sync-mainnet-$(date +'%Y-%m-%d')-in-10h.tar.gz" and use it when tar and untar command

chanhsu001 commented 2 years ago

as liya suggest, temporarily disable sync step and test if it's ok

doitian commented 2 years ago

You can pair with liya on this.

chanhsu001 @.***> 于 2022年3月2日周三 下午10:50写道：

@.**** commented on this pull request.

In ckb-sync-mainnet/script/sync-mainnet.sh https://github.com/nervosnetwork/ckb-integration-test/pull/94#discussion_r817765819 :

@@ -214,8 +215,8 @@ function main() { terraform_apply rust_build ansible_deploy_ckb

  • ansible_wait_ckb_synchronization
  • github_add_comment "$(markdown_report)"

  • ansible_wait_ckb_synchronization

liya suggest to comment/disable actual sync operation when test the patch will work...guess she may mean to do test on my own ckb repo instead of this ckb repo. It's really mess when I really want to do test in Github actions(Sync Mainnet), I do need help on this...

— Reply to this email directly, view it on GitHub https://github.com/nervosnetwork/ckb-integration-test/pull/94#discussion_r817765819, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIXOGIJRP5DQCII6F6GMTU5552LANCNFSM5PWCSFQQ . You are receiving this because you commented.Message ID: @.***>

doitian commented 2 years ago

bors d+

doitian commented 2 years ago

bors try