nervosnetwork / ckb-light-client

CKB light client reference implementation
MIT License
14 stars 16 forks source link

fix: should not send next batch request for filter data when scripts are empty #120

Closed quake closed 1 year ago

quake commented 1 year ago

resolve https://github.com/nervosnetwork/ckb-light-client/issues/119

codecov-commenter commented 1 year ago

Codecov Report

Base: 78.38% // Head: 78.42% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (bcfaf88) compared to base (fc37890). Patch coverage: 92.30% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #120 +/- ## =========================================== + Coverage 78.38% 78.42% +0.03% =========================================== Files 23 23 Lines 4780 4792 +12 =========================================== + Hits 3747 3758 +11 - Misses 1033 1034 +1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `78.42% <92.30%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | Coverage Δ | | |---|---|---| | [...otocols/filter/components/block\_filters\_process.rs](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9maWx0ZXIvY29tcG9uZW50cy9ibG9ja19maWx0ZXJzX3Byb2Nlc3MucnM=) | `95.61% <66.66%> (-0.79%)` | :arrow_down: | | [src/protocols/filter/block\_filter.rs](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9maWx0ZXIvYmxvY2tfZmlsdGVyLnJz) | `86.42% <100.00%> (ø)` | | | [src/storage.rs](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3N0b3JhZ2UucnM=) | `96.63% <100.00%> (+0.03%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.