search

nervosnetwork / ckb-light-client

CKB light client reference implementation
MIT License
14 stars 16 forks source link

Binary builds do not decompress into subdirectory. #143

Open jordanmack opened 1 year ago

jordanmack commented 1 year ago

When decompressing a tarball, the full contents are placed in the current directory rather than a subdirectory. It is more common to decompress into a subdirectory to prevent accidental pollution of the current working directory. This is also more consistent with CKB archives. This was only tested on Linux, but may exist on the other types as well.

ckb-light-client:

username@dev2:~$ wget -q https://github.com/nervosnetwork/ckb-light-client/releases/download/v0.2.3/ckb-light-client_v0.2.3-username@dev2:~$ tar xzf ckb-light-client_v0.2.3-x86_64-linux.tar.gz
username@dev2:~$ ls -lh
-rwxr-xr-x 1 username username  30M May  4 02:23 ckb-light-client
-rw-rw-r-- 1 username username  12M May  4 02:23 ckb-light-client_v0.2.3-x86_64-linux.tar.gz
drwxr-xr-x 2 username username 4.0K May  4 02:09 config

ckb:

username@dev2:~$ wget -q https://github.com/nervosnetwork/ckb/releases/download/v0.109.0/ckb_v0.109.0_x86_64-unknown-linux-gnu.tar.gz
username@dev2:~$ tar xzf ckb_v0.109.0_x86_64-unknown-linux-gnu.tar.gz
username@dev2:~$ ls -lh
drwxr-xr-x 4 username username 4.0K Apr 18 16:39 ckb_v0.109.0_x86_64-unknown-linux-gnu
-rw-rw-r-- 1 username username  27M Apr 18 16:53 ckb_v0.109.0_x86_64-unknown-linux-gnu.tar.gz