nervosnetwork / ckb-light-client

CKB light client reference implementation
MIT License
14 stars 16 forks source link

fix: replace an unreachable with debug logs and ban the peer #146

Closed yangby-cryptape closed 1 year ago

yangby-cryptape commented 1 year ago

Since I could not reproduce the panic in #145 and I haven't figured out why it happened, so I just replace the unreachable with debug logs and ban the peer.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.05 :warning:

Comparison is base (56c09c6) 69.85% compared to head (96883c9) 69.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #146 +/- ## =========================================== - Coverage 69.85% 69.81% -0.05% =========================================== Files 25 25 Lines 6347 6348 +1 =========================================== - Hits 4434 4432 -2 - Misses 1913 1916 +3 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `69.81% <0.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | Coverage Δ | | |---|---|---| | [...s/light\_client/components/send\_last\_state\_proof.rs](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9saWdodF9jbGllbnQvY29tcG9uZW50cy9zZW5kX2xhc3Rfc3RhdGVfcHJvb2YucnM=) | `93.06% <0.00%> (-0.14%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/146/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.