Closed yangby-cryptape closed 11 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
ae04578
) 69.80% compared to head (83c3a6b
) 69.92%. Report is 4 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Commits
Bump toolchain to 1.72.1.
anstyle
requires rustc 1.70.0 or newer.Bump ckb-related crates from 0.109.0 to 0.110.2.
Fix incorrect data in log outputs (introduced since #151).
https://github.com/nervosnetwork/ckb-light-client/blob/d78e15be4618bacb18a5387ce7c6898cf8fe3626/src/protocols/light_client/components/send_last_state_proof.rs#L856-L858
Why don't upgrade CKB-related crates to
v0.111.0
?Depends on CKB-related crates with
v0.111.0-rc8
is fine. But depends on CKB-related crates withv0.111.0-rc9
, thecargo test
under Windows in GitHub Action will be failed; I tried--test-threads 1
and it failed too.:point_right: Click for details.
- Unit tests cause error `STATUS_STACK_BUFFER_OVERRUN` under Windows in GitHub Action (`windows-2019`). - [CKB 0.111.0, Rust 1.72.1 Case-1](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6320902852/job/17164267589) > fatal runtime error: Rust cannot catch foreign exceptions > > (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN) - [CKB 0.111.0, Rust 1.72.1 Case-2](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6320908949/job/17164297189) > memory allocation of 1163692 bytes failed > > (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN) - [CKB 0.111.0, Rust 1.72.1 Case-3](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6320908949/job/17165747116) > memory allocation of 1163692 bytes failed > > (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN) - [CKB 0.111.0, Rust 1.72.1 Case-4 with `--test-threads 1`](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6322165846/job/17167542366) > fatal runtime error: Rust cannot catch foreign exceptions > > (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN) - [CKB 0.111.0, Rust 1.71.1 Case-1](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6323542885/job/17171659331) > thread 'tests::protocols::light_client::send_last_state_proof::valid_proof_with_boundary_not_in_last_n' has overflowed its stack > > (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW) - [CKB 0.111.0, Rust 1.71.1 Case-2](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6323542885/job/17173118779) > fatal runtime error: Rust cannot catch foreign exceptions > > (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW) - Unit tests are slower 3 times under Ubuntu in GitHub Action (CKB 0.111.0, Rust 1.72.1, ubuntu-latest).