codecov-commenter
commented
11 months ago Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
ae04578) 69.80% compared to head (83c3a6b) 69.92%. Report is 4 commits behind head on develop.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #152 +/- ## =========================================== + Coverage 69.80% 69.92% +0.12% =========================================== Files 25 25 Lines 6348 6375 +27 =========================================== + Hits 4431 4458 +27 Misses 1917 1917 ``` | [Flag](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/152/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/152/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | `69.92% <98.64%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | Coverage Δ | | |---|---|---| | [src/protocols/light\_client/mod.rs](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9saWdodF9jbGllbnQvbW9kLnJz) | `69.12% <ø> (ø)` | | | [src/protocols/light\_client/peers.rs](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9saWdodF9jbGllbnQvcGVlcnMucnM=) | `61.22% <100.00%> (-0.06%)` | :arrow_down: | | [...s/light\_client/components/send\_last\_state\_proof.rs](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/152?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9saWdodF9jbGllbnQvY29tcG9uZW50cy9zZW5kX2xhc3Rfc3RhdGVfcHJvb2YucnM=) | `93.21% <98.50%> (+0.14%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/152/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Commits
Bump toolchain to 1.72.1.
anstylerequires rustc 1.70.0 or newer.Bump ckb-related crates from 0.109.0 to 0.110.2.
Fix incorrect data in log outputs (introduced since #151).
https://github.com/nervosnetwork/ckb-light-client/blob/d78e15be4618bacb18a5387ce7c6898cf8fe3626/src/protocols/light_client/components/send_last_state_proof.rs#L856-L858
Why don't upgrade CKB-related crates to
v0.111.0?Depends on CKB-related crates with
v0.111.0-rc8is fine. But depends on CKB-related crates withv0.111.0-rc9, thecargo testunder Windows in GitHub Action will be failed; I tried--test-threads 1and it failed too.:point_right: Click for details.
- Unit tests cause error `STATUS_STACK_BUFFER_OVERRUN` under Windows in GitHub Action (`windows-2019`). - [CKB 0.111.0, Rust 1.72.1 Case-1](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6320902852/job/17164267589) > fatal runtime error: Rust cannot catch foreign exceptions > > (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN) - [CKB 0.111.0, Rust 1.72.1 Case-2](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6320908949/job/17164297189) > memory allocation of 1163692 bytes failed > > (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN) - [CKB 0.111.0, Rust 1.72.1 Case-3](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6320908949/job/17165747116) > memory allocation of 1163692 bytes failed > > (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN) - [CKB 0.111.0, Rust 1.72.1 Case-4 with `--test-threads 1`](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6322165846/job/17167542366) > fatal runtime error: Rust cannot catch foreign exceptions > > (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN) - [CKB 0.111.0, Rust 1.71.1 Case-1](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6323542885/job/17171659331) > thread 'tests::protocols::light_client::send_last_state_proof::valid_proof_with_boundary_not_in_last_n' has overflowed its stack > > (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW) - [CKB 0.111.0, Rust 1.71.1 Case-2](https://github.com/nervosnetwork/ckb-light-client/actions/runs/6323542885/job/17173118779) > fatal runtime error: Rust cannot catch foreign exceptions > > (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW) - Unit tests are slower 3 times under Ubuntu in GitHub Action (CKB 0.111.0, Rust 1.72.1, ubuntu-latest).