search

nervosnetwork / ckb-light-client

CKB light client reference implementation
MIT License
14 stars 16 forks source link

Upgrade ckb dependencies to `0.111.0`, use `cargo-nextest` to run unit tests #153

Closed eval-exec closed 11 months ago

eval-exec commented 11 months ago

This PR do these changes;

  1. chrry-picked https://github.com/nervosnetwork/ckb-light-client/commit/ac8b3c9f21b0076ef43b58197b67adb394205100
  2. use cargo nextest run to run unit tests
eval-exec commented 11 months ago

@quake Please help me trigger the CI action. I want to know if my changes can make the CI on the Windows platform successfully complete.

eval-exec commented 11 months ago

@quake Please re-trigger the CI action.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (5d33576) 69.92% compared to head (1d87316) 69.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #153 +/- ## =========================================== - Coverage 69.92% 69.78% -0.15% =========================================== Files 25 25 Lines 6375 6395 +20 =========================================== + Hits 4458 4463 +5 - Misses 1917 1932 +15 ``` | [Flag](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/153/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/153/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | `69.78% <41.02%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | Coverage Δ | | |---|---|---| | [...s/light\_client/components/send\_last\_state\_proof.rs](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9saWdodF9jbGllbnQvY29tcG9uZW50cy9zZW5kX2xhc3Rfc3RhdGVfcHJvb2YucnM=) | `93.21% <ø> (ø)` | | | [src/verify.rs](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3ZlcmlmeS5ycw==) | `91.48% <100.00%> (+0.47%)` | :arrow_up: | | [src/service.rs](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3NlcnZpY2UucnM=) | `64.73% <0.00%> (ø)` | | | [src/subcmds.rs](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3N1YmNtZHMucnM=) | `0.00% <0.00%> (ø)` | | | [src/storage.rs](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3N0b3JhZ2UucnM=) | `95.89% <0.00%> (-1.00%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

homura commented 10 months ago

Hi, is there a plan to create a release for this PR?

quake commented 10 months ago

we are testing this PR, but we don't have a confirmed release date yet.