search

nervosnetwork / ckb-light-client

CKB light client reference implementation
MIT License
14 stars 16 forks source link

fix: resolve set_scripts partial bug #179

Closed quake closed 7 months ago

quake commented 7 months ago

this PR fixed a bug: stored min_filtered_block_number should be the min of all scripts' block_number when storage's filter_scripts is empty.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d31b8ef) 71.85% compared to head (a30cea5) 71.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #179 +/- ## =========================================== + Coverage 71.85% 71.87% +0.02% =========================================== Files 25 25 Lines 6604 6606 +2 =========================================== + Hits 4745 4748 +3 + Misses 1859 1858 -1 ``` | [Flag](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/179/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nervosnetwork/ckb-light-client/pull/179/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | `71.87% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.