nervosnetwork / ckb-light-client

CKB light client reference implementation
MIT License
14 stars 16 forks source link

feat: introduce a security parameter to optimize the proof size with controlled security #54

Closed yangby-cryptape closed 2 years ago

yangby-cryptape commented 2 years ago

Issue

The previous method, which is used for estimating the samples count, is too simple.

When the total number of blocks in the region which requires verifying is increased, the security is decreased.

Technical Overview

codecov-commenter commented 2 years ago

Codecov Report

Merging #54 (0625396) into develop (ad0fc57) will increase coverage by 0.05%. The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop      #54      +/-   ##
===========================================
+ Coverage    33.13%   33.18%   +0.05%     
===========================================
  Files           22       22              
  Lines         3338     3345       +7     
  Branches       461      464       +3     
===========================================
+ Hits          1106     1110       +4     
- Misses        2120     2121       +1     
- Partials       112      114       +2     
Flag Coverage Δ
unittests 33.18% <66.66%> (+0.05%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/protocols/light_client/sampling.rs 93.93% <66.66%> (-4.37%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.