nervosnetwork / ckb-light-client

CKB light client reference implementation
MIT License
14 stars 16 forks source link

fix: when no samples for a difficulty, the previous sample should be checked #72

Closed yangby-cryptape closed 1 year ago

yangby-cryptape commented 1 year ago

The unit test "samples_are_not_enough_1" will be passed before this fix.

codecov-commenter commented 1 year ago

Codecov Report

Base: 68.08% // Head: 68.40% // Increases project coverage by +0.32% :tada:

Coverage data is based on head (2f53309) compared to base (80356bb). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #72 +/- ## =========================================== + Coverage 68.08% 68.40% +0.32% =========================================== Files 21 21 Lines 3393 3396 +3 =========================================== + Hits 2310 2323 +13 + Misses 1083 1073 -10 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `68.40% <100.00%> (+0.32%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | Coverage Δ | | |---|---|---| | [...s/light\_client/components/send\_last\_state\_proof.rs](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/72/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9saWdodF9jbGllbnQvY29tcG9uZW50cy9zZW5kX2xhc3Rfc3RhdGVfcHJvb2YucnM=) | `84.61% <100.00%> (+1.88%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.