codecov-commenter
commented
1 year ago Codecov Report
Base: 76.75% // Head: 76.86% // Increases project coverage by +0.10% :tada:
Coverage data is based on head (
29e1e47) compared to base (d1e670d). Patch coverage: 83.15% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #79 +/- ## =========================================== + Coverage 76.75% 76.86% +0.10% =========================================== Files 23 23 Lines 4208 4245 +37 =========================================== + Hits 3230 3263 +33 - Misses 978 982 +4 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `76.86% <83.15%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/79?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork) | Coverage Δ | | |---|---|---| | [...s/light\_client/components/send\_last\_state\_proof.rs](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9saWdodF9jbGllbnQvY29tcG9uZW50cy9zZW5kX2xhc3Rfc3RhdGVfcHJvb2YucnM=) | `91.27% <14.28%> (-0.02%)` | :arrow_down: | | [...light\_client/components/send\_transactions\_proof.rs](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9saWdodF9jbGllbnQvY29tcG9uZW50cy9zZW5kX3RyYW5zYWN0aW9uc19wcm9vZi5ycw==) | `91.34% <75.00%> (-6.48%)` | :arrow_down: | | [...ocols/light\_client/components/send\_blocks\_proof.rs](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9saWdodF9jbGllbnQvY29tcG9uZW50cy9zZW5kX2Jsb2Nrc19wcm9vZi5ycw==) | `95.16% <95.83%> (-0.42%)` | :arrow_down: | | [src/protocols/light\_client/peers.rs](https://codecov.io/gh/nervosnetwork/ckb-light-client/pull/79/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork#diff-c3JjL3Byb3RvY29scy9saWdodF9jbGllbnQvcGVlcnMucnM=) | `84.75% <96.87%> (+1.20%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nervosnetwork):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Issues
The old request should always be removed when a response was processed.
But when errors are thrown through the
?operation, the old request is NOT removed.A normal proof could be empty.
Currently, the client consider the last state requires an update when proof is empty.
But the proof is empty doesn't mean there is no proof; maybe the data which you want to prove is enough to prove themselves.
For example, if the last block number is
10, and you want a proof for block[0,1,2,3,4,5,6,7,8,9],then the proof items is empty.Handle missing items for a proof.
p.s. I put them together in one PR, since they all are related to the comparison between the request and the response.