search

nervosnetwork / ckb-sdk-go

MIT License
21 stars 23 forks source link

Add RPC Support for ckb `v0.109 -> 0.117` #221

Closed eval-exec closed 3 months ago

eval-exec commented 3 months ago

Fix https://github.com/nervosnetwork/ckb-sdk-go/issues/220

eval-exec commented 3 months ago

@quake Please help me execute the workflows image

eval-exec commented 3 months ago 
go: downloading github.com/aristanetworks/goarista v0.0.0-20170210015632-ea17b1a17847
go: downloading golang.org/x/sys v0.0.0-[20](https://github.com/nervosnetwork/ckb-sdk-go/actions/runs/10314934806/job/28555511295?pr=221#step:4:21)220422013727-9388b58f7150
ok      github.com/nervosnetwork/ckb-sdk-go/v2/address  0.026s
# github.com/nervosnetwork/ckb-sdk-go/v2/transaction/signer_test [github.com/nervosnetwork/ckb-sdk-go/v2/transaction/signer.test]
Error: transaction/signer/example_test.go:20:44: not enough arguments in call to ctx.rpc.GetLiveCell
    have (context.Context, *types.OutPoint, bool)
    want (context.Context, *types.OutPoint, bool, *bool)
ok      github.com/nervosnetwork/ckb-sdk-go/v2/collector    2.405s

Don't know why the test failed. I can't find example_test.go file.

eval-exec commented 3 months ago

@quake Please rerun the failed CI workflow.

eval-exec commented 3 months ago 
go: downloading github.com/aristanetworks/goarista v0.0.0-20170210015632-ea17b1a17847
go: downloading golang.org/x/sys v0.0.0-[20](https://github.com/nervosnetwork/ckb-sdk-go/actions/runs/10314934806/job/28555511295?pr=221#step:4:21)220422013727-9388b58f7150
ok    github.com/nervosnetwork/ckb-sdk-go/v2/address  0.026s
# github.com/nervosnetwork/ckb-sdk-go/v2/transaction/signer_test [github.com/nervosnetwork/ckb-sdk-go/v2/transaction/signer.test]
Error: transaction/signer/example_test.go:20:44: not enough arguments in call to ctx.rpc.GetLiveCell
  have (context.Context, *types.OutPoint, bool)
  want (context.Context, *types.OutPoint, bool, *bool)
ok    github.com/nervosnetwork/ckb-sdk-go/v2/collector    2.405s

Don't know why the test failed. I can't find example_test.go file.

Rebased, I beleave CI will success now. @quake

eval-exec commented 3 months ago

@quake I commented TestGetCellsMaxLimit, fix it later.