search

nervosnetwork / ckb

The Nervos CKB is a public permissionless blockchain, and the layer 1 of Nervos network.
https://www.nervos.org
MIT License
1.17k stars 233 forks source link

`get_fee_rate_statistics` returns apparently incorrect data on devnet #4350

Closed phroi closed 1 month ago

phroi commented 9 months ago

Hello folks at Nervos, I'm running a devnet for testing iCKB and I see an unexpected behavior.

Current Behavior

I have a stream of transactions with 1000 feeRate, but then when I check get_fee_rate_statistics both mean and median feeRate seems almost double. So went back to my code, I double checked and my transactions indeed have the intended feeRate, I'm not overpaying.

Also I tried increasing the feeRate to 10^9, but get_fee_rate_statistics consistently returns around double of the intended fee rate.

Also I tried setting feeRate to 999 and indeed the txPool reject the transaction as expected.

Expected Behavior

get_fee_rate_statistics should return feeRate mean and median of the past transactions feeRate.

Environment

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 4 months ago

This issue was closed because it has been stalled for 5 days with no activity.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

phroi commented 1 month ago

Just tested: fee_rate still explodes on devnet :man_shrugging:

eval-exec commented 1 month ago

Just tested: fee_rate still explodes on devnet :man_shrugging:

Sorry, this right fix will be in 0.119.0 https://github.com/nervosnetwork/ckb/pull/4654

eval-exec commented 1 month ago

Ref: https://github.com/nervosnetwork/ckb/releases/tag/v0.119.0

eval-exec commented 1 month ago

I think we can close this issue.