(chore): Add cargo shear to check crates - Githubissues

nervosnetwork / ckb

The Nervos CKB is a public permissionless blockchain, and the layer 1 of Nervos network.

https://www.nervos.org

MIT License

1.16k stars 228 forks source link

(chore): Add cargo shear to check crates #4399

Closed chenyukang closed 7 months ago

chenyukang commented 7 months ago

What problem does this PR solve?

Use bash script with pattern match to check unused crates seems slow and not easy to maintain, cargo-shear is a better tool for this task.

While it has false positive warnings caused by macros, we can add them to the ignored list.

What is changed and how it works?

What's Changed:

Add cargo-shear into devtools/ci/check-cargotoml.sh
Trivial cleanup for performance

Related changes

PR to update owner/repo:
Need to cherry-pick to the release branch

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code ci-runs-only: [ quick_checks,linters ]

Release note

None: Exclude this PR from the release note.