[Breaking Change] Fix default `ckb.toml`'s `[notifier]` to `[notify]` - Githubissues

nervosnetwork / ckb

The Nervos CKB is a public permissionless blockchain, and the layer 1 of Nervos network.

https://www.nervos.org

MIT License

1.16k stars 228 forks source link

[Breaking Change] Fix default `ckb.toml`'s `[notifier]` to `[notify]` #4405

Closed eval-exec closed 6 months ago

eval-exec commented 7 months ago

What problem does this PR solve?

The [notifier] should be [notify]

https://github.com/nervosnetwork/ckb/blob/6ae6d0624ac524ddb08fbeea1f6835e3b16cac9d/util/app-config/src/legacy/mod.rs#L58-L59

Related changes

PR to update owner/repo:
Need to cherry-pick to the release branch

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code ci-runs-only: [ quick_checks,linters ]

Side effects

None

Release note

Title Only: Include only the PR title in the release note.

eval-exec commented 7 months ago

TODO:

[x] add a bats-cli test