Prevent `ckb-shared` import `ckb-db-schema` - Githubissues

nervosnetwork / ckb

The Nervos CKB is a public permissionless blockchain, and the layer 1 of Nervos network.

https://www.nervos.org

MIT License

1.15k stars 228 forks source link

Prevent `ckb-shared` import `ckb-db-schema` #4524

Open eval-exec opened 1 month ago

eval-exec commented 1 month ago

What problem does this PR solve?

Problem Summary:

I believe that loading the COLUMN_NUMBER_HASH data in ckb-shared is not appropriate; it should be moved to ckb-store.

What is changed and how it works?

Related changes

[x] Move loading the COLUMN_NUMBER_HASH data function from ckb-shared to ckb-store
[ ] Move loading the COLUMN_BLOCK_BODY data function from ckb-shared to ckb-store

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code ci-runs-only: [ quick_checks,linters ]

Side effects

None

Release note

Title Only: Include only the PR title in the release note.