`VerifyQueue`: re_notify other Worker when `OnlySmallCycleTx` received a large cycle tx

nervosnetwork / ckb

The Nervos CKB is a public permissionless blockchain, and the layer 1 of Nervos network.

https://www.nervos.org

MIT License

1.15k stars 228 forks source link

`VerifyQueue`: re_notify other Worker when `OnlySmallCycleTx` received a large cycle tx #4591

Closed eval-exec closed 1 month ago

eval-exec commented 1 month ago

What problem does this PR solve?

we found SendLargeCyclesTxToRelay is not stable, seems some large cycle tx is not properly processed when replay.

The root cause is when verify_queue wake up a OnlySmallCycleTx to large cycle tx, the worker will directly return, then other worker also miss the chance to pick it up.

Related changes

Let Worker::process_inner re_notify other workers if current worker is a OnlySmallCycleTx Worker, but there is large cycle tx in VerifyQueue

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code ci-runs-only: [ quick_checks,linters ]

Side effects

None

Release note

Title Only: Include only the PR title in the release note.

eval-exec commented 1 month ago


--- STDOUT:              ckb-script verify::tests::ckb_2021::features_since_v2023::check_infinite_exec ---

running 1 test
test verify::tests::ckb_2021::features_since_v2023::check_infinite_exec has been running for over 60 seconds
test verify::tests::ckb_2021::features_since_v2023::check_infinite_exec ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 404 filtered out; finished in 71.69s

     SIGABRT [   3.389s] ckb-sync tests::synchronizer::functions::test_sync_process

--- STDOUT:              ckb-sync tests::synchronizer::functions::test_sync_process ---

running 1 test
test tests::synchronizer::functions::test_sync_process ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 68 filtered out; finished in 3.29s

--- STDERR:              ckb-sync tests::synchronizer::functions::test_sync_process ---
pthread lock: Invalid argument

eval-exec commented 1 month ago

Retry merge...

chenyukang commented 1 month ago

emm, what this error...

eval-exec commented 1 month ago

I think this error may related to Rocksdb's OptimisticTransaction

On 8/15/24 7:56 PM, Yukang @.***> wrote:

emm, what this error...

— Reply to this email directly, view it on GitHub https://github.com/nervosnetwork/ckb/pull/4591#issuecomment-2291138383, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCAINXMQAJWJYJCBMQEXPDZRSJPDAVCNFSM6AAAAABMR56EGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGEZTQMZYGM. You are receiving this because you modified the open/close state.Message ID: @.***>