Closed chenyukang closed 3 weeks ago
ForksContainSameUncle has the chance of 1/10 to fail in my local machine with error Uncles(DoubleInclusion), after debugging I found the uncle block hash is same with new block hash in node_b.mine(1).
ForksContainSameUncle
Uncles(DoubleInclusion)
uncle
This issue was fixed in https://github.com/nervosnetwork/ckb/commit/0dc63c2c0cc947b0f1916579a15a27f3d2054421
But it's reverted in the following changes, I believe it is unintentional.
Make sure the uncle block timestamp is different from the next block timestamp in main fork
What's Changed:
owner/repo
Tests
None: Exclude this PR from the release note.
What problem does this PR solve?
ForksContainSameUncle
has the chance of 1/10 to fail in my local machine with errorUncles(DoubleInclusion)
, after debugging I found theuncle
block hash is same with new block hash in node_b.mine(1).This issue was fixed in https://github.com/nervosnetwork/ckb/commit/0dc63c2c0cc947b0f1916579a15a27f3d2054421
But it's reverted in the following changes, I believe it is unintentional.
What is changed and how it works?
Make sure the uncle block timestamp is different from the next block timestamp in main fork
What's Changed:
Related changes
owner/repo
:Check List
Tests
Release note