nervosnetwork / ckb

The Nervos CKB is a public permissionless blockchain, and the layer 1 of Nervos network.
https://www.nervos.org
MIT License
1.17k stars 232 forks source link

Don't ban remote peer when ckb_vm received Ctrl-C signal when processing chunk_tx #4702

Closed eval-exec closed 3 days ago

eval-exec commented 1 month ago

What problem does this PR solve?

Issue Number: close #4701

Related changes

return ErrorKind::Internal then ckb will not think the tx is malformled: https://github.com/nervosnetwork/ckb/blob/8cb49e4d727f337a2c80e210507a9e277bab3391/util/types/src/core/tx_pool.rs#L68-L84

Check List

Tests

Side effects

Release note

Title Only: Include only the PR title in the release note.
chenyukang commented 1 month ago

seems not a proper PR title.

eval-exec commented 1 month ago

seems not a proper PR title.

Got it, I'll update the title. Any suggestions?

eval-exec commented 1 month ago

Need to create a new Error to handle this case:InternalErrorKind::Interrupts

chenyukang commented 1 week ago

how can we add a unit test for this, it seems hard but worth having a try.

eval-exec commented 1 week ago

how can we add a unit test for this, it seems hard but worth having a try.

Sure, I will add unit test.